Add statefulsets to the dashboard and CLI #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Sim <ivan@buoyant.io>
ihcsim
force-pushed
the
isim/statefulsets-stats
branch
from
c4fe1f8 to
96ef90c
Compare
siggy
reviewed
Feb 8, 2019
There was a problem hiding this comment.
awesome! mostly cosmetic comments around statefulset -> sts, and sorting resource types.
we are not great about sorting our k8s resource types, but as the number of types grows, i think it becomes more important. not every code path uses exactly the same set of resources, so sort order helps in identifying differences. i noted a few particular sorting locations in the code review, but not all of them. with that in mind, a few guiding principles:
- if a list of resources is already sorted, keep it sorted
- if you encounter code where sorting is not correct, feel empowered to clean it up
- there may be exceptions for UI/doc purposes. the stat help output sorts some exceptional resources at the bottom, but all things being equal, i'd recommend resorting the first 6 items together, then sort the 3 exceptional types together, and then
allat the bottom.
Valid resource types include:
* daemonsets
* deployments
* namespaces
* pods
* replicationcontrollers
* statefulsets
* authorities (not supported in --from)
* jobs (only supported as a --from or --to)
* services (only supported if a --from is also specified, or as a --to)
* all (all resource types, not supported in --from or --to)
Signed-off-by: Ivan Sim <ivan@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds statefulset resources to the dashboard, CLI and grafana. Note that at present, no TCP metrics will appear. See #2223 and #2224.
The screenshots below show test results with redis and nginx, used to demonstrate http and tcp traffic metrics.
Fixes #1983
Signed-off-by: Ivan Sim ivan@buoyant.io